Added build tag to include version info in Docker build #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alesstimec
approved these changes
Jul 4, 2023
| @@ -32,6 +33,10 @@ func main() { | |||
|
|
|||
| // start initialises the jimmsrv service. | |||
| func start(ctx context.Context, s *service.Service) error { | |||
| zapctx.Info(ctx, "jimm info", | |||
There was a problem hiding this comment.
do we need this since it's available via /debug/info endpoint?
There was a problem hiding this comment.
It's nice for seeing in the logs especially when you can't get the server to start due to missing config, at least this way you have a way to see what version of the server is running, will prevent some confusion in the future I'm sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the build of the JIMM binary in the Dockerfile to include version info. Also added a log when the service starts to output the version and commit hash. Removed the
-raceflag since this this binary is part of the production build.These changes will land in
feature-rebacin a separate pr whenmainis merged intofeature-rebac.Engineering checklist
Check only items that apply